feat(provider-sdk): add run_provider_handler
#1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvolosatovs
force-pushed
the
feat/provider-sdk-init
branch
3 times, most recently
from
7888c4a
to
9d837de
Compare
rvolosatovs
changed the title
init_providerrun_provider_handler
There was a problem hiding this comment.
This all looks fine to me, @vados-cosmonic deferring to you on review for anything in the bindgen macro etc etc
|
@brooksmtownsend will do. This is going to break my other PRs but let's get this merged in first since it's a good refactor of |
vados-cosmonic
approved these changes
Mar 12, 2024
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
rvolosatovs
force-pushed
the
feat/provider-sdk-init
branch
from
674f5da
to
364ccd0
Compare
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
rvolosatovs
force-pushed
the
feat/provider-sdk-init
branch
from
364ccd0
to
5e33655
Compare
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
brooksmtownsend
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
run_provider_handlerfor building providers using justProviderHandlertrait implementations, which manually serve using returnedwrpc_transport::Client(e.g. all handwritten providers)Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification