feat(provider-sdk)!: rename put_link to receive_link_config_as_* #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit renames `put_link` which was a part of the `ProviderHandler` trait to `receive_link_config_as_target` and `receive_link_config_as_source` depending on the position of the provider when the link is put. With both of these explicit methods, users should be able to configure their providers appropriately depending on how the link has been put to them. Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
brooksmtownsend
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This commit renames
put_linkwhich was a part of theProviderHandlertrait toreceive_link_config_as_targetandreceive_link_config_as_sourcedepending on the position of the provider when the link is put.With both of these explicit methods, users should be able to configure their providers appropriately depending on how the link has been put to them.
Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification