Wash up should be idempotent. #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdmurph32
force-pushed
the
cdmurph32/846
branch
4 times, most recently
from
c408038
to
cdb3515
Compare
cdmurph32
force-pushed
the
cdmurph32/846
branch
from
cdb3515
to
4a701a9
Compare
thomastaylor312
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Sorry for the delay @cdmurph32, got sidetracked with KubeCon stuff. I'm good with this pending passing tests. Might be worth rebasing to make sure you picked up any of the other test fixes we added in
|
I'm still trying to get the integration tests working. I should be able to get it done tomorrow. |
cdmurph32
force-pushed
the
cdmurph32/846
branch
from
4a701a9
to
07d62e4
Compare
|
All of the tests are working locally for me now. This is ready for review again. |
cdmurph32
force-pushed
the
cdmurph32/846
branch
from
07d62e4
to
1de1917
Compare
If a wasmcloud host is runnning, `wash up` will not start an additional host unless `--scale` is passed. When starting multiple hosts, NATS should be run independently of wasmcloud, otherwise killing the original `wash up` will also stop NATS. Signed-off-by: Colin Murphy <cdmurph32@gmail.com>
Signed-off-by: Colin Murphy <cdmurph32@gmail.com>
Signed-off-by: Colin Murphy <cdmurph32@gmail.com>
Signed-off-by: Colin Murphy <cdmurph32@gmail.com>
Signed-off-by: Colin Murphy <cdmurph32@gmail.com>
cdmurph32
force-pushed
the
cdmurph32/846
branch
from
1de1917
to
18469f7
Compare
thomastaylor312
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a wasmcloud host is runnning,
wash upwill not start an additional host unless--scaleis passed.When starting multiple hosts, NATS should be run independently of wasmcloud, otherwise killing the original
wash upwill also stop NATS.Feature or Problem
Wash up should be idempotent #846
Related Issues
Release Information
Consumer Impact
This will change how users start multiple wasmCloud hosts on the same machine
Testing
Integration test added.
Unit Test(s)
Acceptance or Integration
Manual Verification