feat(wash-cli)!: wash config put/get/del implementation #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksmtownsend
force-pushed
the
feat/wrpc-compatible-wash
branch
2 times, most recently
from
4a3b06e
to
57f894c
Compare
brooksmtownsend
force-pushed
the
feat/wash-config-command
branch
2 times, most recently
from
b040b9c
to
5adeec1
Compare
thomastaylor312
requested changes
Mar 15, 2024
brooksmtownsend
force-pushed
the
feat/wrpc-compatible-wash
branch
from
57f894c
to
2f2b8c9
Compare
brooksmtownsend
force-pushed
the
feat/wash-config-command
branch
from
5adeec1
to
bebfe2f
Compare
brooksmtownsend
force-pushed
the
feat/wrpc-compatible-wash
branch
from
2f2b8c9
to
17493b5
Compare
brooksmtownsend
force-pushed
the
feat/wash-config-command
branch
from
bebfe2f
to
9fb1b2d
Compare
brooksmtownsend
force-pushed
the
feat/wrpc-compatible-wash
branch
from
17493b5
to
fb25d93
Compare
brooksmtownsend
force-pushed
the
feat/wash-config-command
branch
from
9fb1b2d
to
8ffb7a7
Compare
brooksmtownsend
force-pushed
the
feat/wrpc-compatible-wash
branch
from
0b8008e
to
838e380
Compare
brooksmtownsend
force-pushed
the
feat/wash-config-command
branch
from
8ffb7a7
to
9ed888c
Compare
brooksmtownsend
force-pushed
the
feat/wrpc-compatible-wash
branch
2 times, most recently
from
109a400
to
b53999e
Compare
brooksmtownsend
force-pushed
the
feat/wash-config-command
branch
from
9ed888c
to
cdfaf42
Compare
thomastaylor312
approved these changes
Mar 17, 2024
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com> feat(wash-cli)\!: implement config subcommand Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com> remove config caches Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
brooksmtownsend
force-pushed
the
feat/wash-config-command
branch
from
cdfaf42
to
86776bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR implements the
wash configsubcommand, includingget,put, anddel.I had to make a change in the host to actually watch the config data bucket to get updates on config, so tests for this feature in wash will have to wait for the next alpha wasmcloud release.
Related Issues
Release Information
wasmcloud v1.0.0-alpha.2
next wash
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification
I manually made sure all of this worked! I also included a special case to ensure we aren't inserting
success:truewhen people fetch JSON config, might conflict with their keys and/or cause confusion.