Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build providers #1701

Merged
merged 4 commits into from
Mar 19, 2024
Merged

ci: build providers #1701

merged 4 commits into from
Mar 19, 2024

Conversation

rvolosatovs
Copy link
Member

@rvolosatovs rvolosatovs commented Mar 19, 2024

Feature or Problem

Make providers part of the workspace and build them alongside wasmcloud binary. CI for actually turning these into PARs will follow.

I'm hoping we can get this PR merged fast to avoid painful merge conflicts later

  • remove the need for custom build scripts for providers
  • ensure that providers are built for all targets supported by wasmcloud host (note, how blobstore-fs being broken on Windows was uncovered by this PR)
  • use consistent provider naming scheme
  • simplify dependency management (which should, in fact, improve our Nix caching performance)
  • update nixify to pull in fix for fix(rust): handle binaries in src/bin/$name/ rvolosatovs/nixify#220
  • run provider unit tests (which were ignored up to this point) - the broken ones are ignored for now

It's still possible to build wasmcloud with --no-default-features to avoid building the providers and only build the host binary.

Related Issues

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

@rvolosatovs rvolosatovs force-pushed the ci/providers branch 7 times, most recently from b714849 to 3511588 Compare March 19, 2024 15:04
@rvolosatovs rvolosatovs marked this pull request as ready for review March 19, 2024 15:12
@rvolosatovs rvolosatovs requested review from a team as code owners March 19, 2024 15:12
@rvolosatovs rvolosatovs enabled auto-merge (rebase) March 19, 2024 15:12
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
@rvolosatovs rvolosatovs marked this pull request as draft March 19, 2024 15:24
auto-merge was automatically disabled March 19, 2024 15:24

Pull request was converted to draft

Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
@rvolosatovs rvolosatovs marked this pull request as ready for review March 19, 2024 15:32
@rvolosatovs rvolosatovs enabled auto-merge (rebase) March 19, 2024 15:33
Copy link
Contributor

@thomastaylor312 thomastaylor312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way nicer. Great job here

@rvolosatovs rvolosatovs merged commit daec0dd into wasmCloud:main Mar 19, 2024
46 checks passed
@rvolosatovs rvolosatovs deleted the ci/providers branch March 19, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants