Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update test-actors dependencies #1703

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

rvolosatovs
Copy link
Member

Feature or Problem

Related Issues

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
@rvolosatovs rvolosatovs requested a review from a team as a code owner March 19, 2024 15:58
@rvolosatovs rvolosatovs enabled auto-merge (rebase) March 19, 2024 16:01
apparently latest `wit-bindgen` uses unsafe

Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
@rvolosatovs rvolosatovs marked this pull request as draft March 22, 2024 16:52
auto-merge was automatically disabled March 22, 2024 16:52

Pull request was converted to draft

@rvolosatovs
Copy link
Member Author

Integrated in #1736

@rvolosatovs rvolosatovs marked this pull request as ready for review March 22, 2024 17:21
@rvolosatovs rvolosatovs enabled auto-merge (rebase) March 22, 2024 17:22
Copy link
Member

@brooksmtownsend brooksmtownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with all these changes especially since these are test components, and I do want to move away from all usages of "actor" in the future where possible. Do you think that using "Component" as a struct name is too confusing? I think we can help people understand what the best name is to use for their structs

@rvolosatovs rvolosatovs merged commit 683295f into wasmCloud:main Mar 22, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants