feat(*)!: rename actor_scale* events #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
thomastaylor312
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR renames the
actor_scaledandactor_scale_failedevent tocomponent_scaledandcomponent_scale_failed. It's the last breaking change (that I know of) with the rename that we should do pre-1.0.In this PR I also adjusted wash + wash-lib to deal with both events to ease the transition.
Related Issues
Release Information
Consumer Impact
Consumers like wadm will need to update their event to instead handle component scaled.
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification