Revert "fix(wash-lib): changed the variable name for a cleaner code" #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit edc660d. Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
This reverts commit ddf25d9. Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
…onstructs@gmail.com>" This reverts commit 04bdd40. Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
…nstructs directory and modified test cases" This reverts commit 2e93989. Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
This reverts commit cd901db. Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
brooksmtownsend
force-pushed
the
revert-1685-issue#1624
branch
from
bac9043
to
b64d886
Compare
thomastaylor312
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit edc660d.Reverts #1685
This was a good change, but it was failing a test. Reverting for now, @siddharthkhonde it should be pretty simple to re-open the change here just with the test fix