chore(host): imrpove wording for spec/provider ref mismatch #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit slightly improves the wording when a provider ID and component specification URL mismatch occurs, along with specifying a possible solution. This error is thrown by `wash` and it's a bit difficult to figure out what to resolve it otherwise. Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
brooksmtownsend
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Ah shoot, we should probably remove this check anyways to match the change in #1829 . No harm in inserting this, but you could just remove the check entirely in favor of checking to see if the provider is already running.
Since there's no update provider command, I think we definitely have to allow people to overwrite it
vados-cosmonic
deleted the
chore(host)=improve-wording-for-spec-url-mismatch
branch
|
Yeah I'm a bit wary as people need to be careful not to depend on the values in there without checking for updates, but will follow up with a removal of the check! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This commit slightly improves the wording when a provider ID and component specification URL mismatch occurs, along with specifying a possible solution.
This error is thrown by
washand it's a bit difficult to figure out what to resolve it otherwise.Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification