fix(examples): Hello world component examples #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
brooksmtownsend
changed the title
brooksmtownsend
force-pushed
the
fix/1.0-examples
branch
3 times, most recently
from
aec55b7
to
dc62d88
Compare
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com> fix: go example Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com> fix go Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com> fix go Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com> fix(examples): update python component kv dep Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
brooksmtownsend
force-pushed
the
fix/1.0-examples
branch
from
dc62d88
to
3046158
Compare
ricochet
approved these changes
Apr 10, 2024
thomastaylor312
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR removes the outdated actor example, updates the wit-bindgen dependency and wit worlds in the Rust http hello world component, and commits the "finalized" version of our quickstart as the http-keyvalue-counter example. I plan to do the exact same thing as our other examples, but I'll keep the PRs as small as I can.
I refactored some of the manifest names and component names to be more consistent and shorter so we can have nice generated IDs with wadm.
I went ahead and just ran a
wit-depsupdate in the Python, TinyGo, and Typescript examples directories but I need to validate that worked properly.Related Issues
Release Information
I'd love to get both the http hello world and keyvalue counter examples released eventually, to serve as a common base.
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification