test(wash): re-enable wash call test #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vados-cosmonic
force-pushed
the
test(wash)=re-enable-wash-call-test
branch
from
f8b08be
to
582faeb
Compare
|
Looks like some upstream changes have fixed |
vados-cosmonic
force-pushed
the
test(wash)=re-enable-wash-call-test
branch
5 times, most recently
from
8de8f99
to
6c205ff
Compare
brooksmtownsend
requested changes
Apr 16, 2024
vados-cosmonic
force-pushed
the
test(wash)=re-enable-wash-call-test
branch
4 times, most recently
from
115511d
to
d8c5c1d
Compare
|
Hey @brooksmtownsend I thought that we should add a bit more customization here, especially if we're going to show off |
vados-cosmonic
force-pushed
the
test(wash)=re-enable-wash-call-test
branch
3 times, most recently
from
1d55ddc
to
96c3c9e
Compare
vados-cosmonic
force-pushed
the
test(wash)=re-enable-wash-call-test
branch
from
96c3c9e
to
6535af6
Compare
brooksmtownsend
approved these changes
Apr 17, 2024
This commit re-enables the test for `wash call` that used to exist prior to wRPC MVP integration. To do this, we enable `wash call` to work for components that implement the `wasi:http/incoming-handler` interface, taking a JSON-fiied representation of a request (or a GET by defaul) and invoking the relevant component. Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
vados-cosmonic
force-pushed
the
test(wash)=re-enable-wash-call-test
branch
from
6535af6
to
63933f9
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
Resolves #1644
Related Issues
Release Information
This PR modifies
wash callto be able to support sending HTTP requests to actors that implementwasi:http/incoming-handler.handleConsumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification