-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(examples): remove redundant world spec #1930
chore(examples): remove redundant world spec #1930
Conversation
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure we want to do this? This is going to be worse for anyone looking at these to learn.
The fact that the world is auto-selected is not immediately obvious, but world: "..."
makes it more explicit. We shouldn't depend on implicit functionality when someone completely new to the ecosystem might be showing up.
Maybe adding a comment to explain the mechanism would make sense -- wit_bindgen
options and functionality are not very well documented at all, upstream.
People completely new to the ecosystem are very unlikely to have more than one world defined in their WIT packages - it's an advanced feature and if anything, we should be steering developers away from it to avoid confusion. In any case, these examples should not be using |
The point wasn't that they're going to use the To illustrate, the term in there would be grep-able at the very least -- if you named your world
That's a reasonable point! We build with |
In the interest of not holding up 1.0, we'll get this in and hopefully no one is confused by it |
prioritizing chages making it in before 1.0
Feature or Problem
Remove the redundant
world
specification forwit-bindgen
invocations. It's not necessary when there's only one world in the packageRelated Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification