Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wash-lib)!: make link del interface consistent #1962

Merged
merged 4 commits into from Apr 19, 2024

Conversation

brooksmtownsend
Copy link
Member

@brooksmtownsend brooksmtownsend commented Apr 19, 2024

Feature or Problem

This PR makes the wash link del interface consistent with link put, renames an actor->component in build output, and adds an alias that follows our general noun verb pattern with a more common word (link query == link get).

I also updated the README while I was in there.

Related Issues

Fixes #1926
Fixes #1941

Release Information

wash-lib next minor
wash-cli next minor

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

I did verify the new wash link del command works

Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>

consistent

Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>

moar consistent

Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
@brooksmtownsend brooksmtownsend requested a review from a team as a code owner April 19, 2024 18:01
Copy link
Contributor

@vados-cosmonic vados-cosmonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@brooksmtownsend brooksmtownsend merged commit 8b00bd3 into main Apr 19, 2024
66 checks passed
@brooksmtownsend brooksmtownsend deleted the fix/wash-link-del branch April 19, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CHORE: Update README for wash-cli [FEATURE] Add a wit positional argument to wash link del
2 participants