fix(host): remove extra component_scaled events

[yerzham]

Signed-off-by: Yerzhan Zhamashev yerzhan.contribs@novel.systems

Problem

When a component is scaled to a max instances value of 0, we emit two component_scaled events that assert that it was scaled to zero.

Similarly, an extra component_scaled event with max_instances: 0 is emitted for wash scale and wash update.

Related Issues

#1888

Release Information

wasmCloud v1.0

Consumer Impact

Extra component_scaled event with max_instances: 0 is no longer emitted when a component is updated or scaled (and scaled to 0 i.e stopped)

Testing

All tests should work as expected

Manual Verification

Listening to wasmbus.evt.> on NATS while performing wash start, wash scale, wash update, and wash stop on a component.

[brooksmtownsend]

With some testing, looks great! I left two comments + requests to remove the TODO comments if they aren't tied to an open issue so we don't accumulate questions around the codebase without action items 😄

[brooksmtownsend]

Thank you @yerzham ! It looks like the only other thing you need here is a DCO signoff, which you had in the first commit. The DCO failed action will give you the easy fix for this https://github.com/wasmCloud/wasmCloud/pull/1968/checks?check_run_id=24113309713

[yerzham]

oops, will fix that

[brooksmtownsend]

Should be good to cut this as a patch release 🚀