Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blobby): rename link scaler #1997

Merged
merged 1 commit into from Apr 29, 2024
Merged

fix(blobby): rename link scaler #1997

merged 1 commit into from Apr 29, 2024

Conversation

brooksmtownsend
Copy link
Member

@brooksmtownsend brooksmtownsend commented Apr 29, 2024

Feature or Problem

This PR fixes an issue where the link in the blobby manifest was getting parsed incorrectly.

Related Issues

Fixes #1996

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

I did verify this works

@brooksmtownsend brooksmtownsend requested a review from a team as a code owner April 29, 2024 12:49
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Copy link
Contributor

@vados-cosmonic vados-cosmonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 thanks for the fast fix

@vados-cosmonic vados-cosmonic merged commit 309806a into main Apr 29, 2024
73 checks passed
@vados-cosmonic vados-cosmonic deleted the fix/blobby-link branch April 29, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Blobby example, unknown "wasi:blobstore/blobstore" target
2 participants