Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/host errors #630

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Conversation

connorsmith256
Copy link
Contributor

@connorsmith256 connorsmith256 commented Sep 7, 2023

Feature or Problem

This PR fixes two bugs in the host:

  • the host was looking for the wrong object store IDs when parsing chunked invocation responses
  • the host was dropping context when writing errors to the guest

Release Information

v0.78.0-rc5

Consumer Impact

The host should now be able to receive chunked invocation responses on behalf of actors

Testing

Built on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Tested on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Unit Test(s)

Acceptance or Integration

Manual Verification

Tested e2e manually:

wash start actor -x default -p 4222 ghcr.io/connorsmith256/beeg-image:0.1.0
wash start provider -x default -p 4222 wasmcloud.azurecr.io/httpclient:0.8.0
wash start provider -x default -p 4222 wasmcloud.azurecr.io/httpserver:0.19.1
wash link put -x default -p 4222 MBDBBXENIJQ2YOBD4D6HKLGEVDUXTRO3HHLZVNI6LJRUPVOSNZGSKLD6 VAG3QITQQ2ODAOWB5TTQSDJ53XK3SHBEIFNK4AYJ5RKAX2UNSCAPHA5M wasmcloud:httpserver address=0.0.0.0:8080
wash link put -x default -p 4222 MBDBBXENIJQ2YOBD4D6HKLGEVDUXTRO3HHLZVNI6LJRUPVOSNZGSKLD6 VCCVLH4XWGI3SGARFNYKYT2A32SUYA2KVAIV2U2Q34DQA7WWJPFRKIKM wasmcloud:httpclient

Then navigated to the browser at http://127.0.0.1:8080/ and confirmed the large (3MB) image loads successfully

Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
rvolosatovs
rvolosatovs previously approved these changes Sep 7, 2023
Copy link
Member

@rvolosatovs rvolosatovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error messages are broken, but that was already the case before the PR

crates/core/src/chunking.rs Outdated Show resolved Hide resolved
Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
@connorsmith256 connorsmith256 merged commit 0e6e2da into wasmCloud:main Sep 7, 2023
23 checks passed
@connorsmith256 connorsmith256 deleted the fix/host-errors branch September 7, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants