fix: allow namespaces with slashes #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
connorsmith256
requested review from
rvolosatovs,
autodidaddict,
brooksmtownsend and
thomastaylor312
as code owners
brooksmtownsend
approved these changes
Sep 7, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR fixes a bug where we implicitly assumed namespaces wouldn't contain slashes. However, since call aliases can be defined by users, and our own examples include slashes in call aliases, this assumption is violated.
Instead, we assume the operation string
Interface.Methodwon't contain slashes, and split from the rightRelated Issues
Release Information
0.78.0-rc6
Consumer Impact
Users can now invoke actors via call aliases that include slashes
Testing
Built on platform(s)
Tested on platform(s)
Unit Test(s)
Updated tests to use a call alias with a slash
Acceptance or Integration
Manual Verification
Manually tested actor-to-actor calls with aliases which include a slash (pingpong example)