Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add riscv64gc-unknown-linux-gnu build #741

Merged
merged 3 commits into from
Nov 20, 2023
Merged

build: add riscv64gc-unknown-linux-gnu build #741

merged 3 commits into from
Nov 20, 2023

Conversation

rvolosatovs
Copy link
Member

@rvolosatovs rvolosatovs commented Oct 10, 2023 •
edited

Feature or Problem

Provide RISCV64 GNU binaries (musl is.. complicated for now)

Related Issues

Closes #724
Closes #853
Blocked on wasmCloud/wadm@2e0e333
Blocked on #935

Release Information

Consumer Impact

Testing

Built on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Tested on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Unit Test(s)

Acceptance or Integration

Manual Verification

@rvolosatovs
Copy link
Member Author 

2023-10-10T17:25:14.4462148Z wasmcloud-deps> error: failed to run custom build command for `ring v0.16.20`
2023-10-10T17:25:14.4464761Z wasmcloud-deps> Caused by:
2023-10-10T17:25:14.4466525Z wasmcloud-deps>   process didn't exit successfully: `/build/source/target/release/build/ring-acd2e0b54442fb65/build-script-build` (exit status: 101)
2023-10-10T17:25:14.4468087Z wasmcloud-deps>   --- stderr
2023-10-10T17:25:14.4470220Z wasmcloud-deps>   thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /nix/store/mkhnj63qi3gpnh1xrzp1ldb8im8jlf55-vendor-cargo-deps/c19b7c6f923b580ac259164a89f2577984ad5ab09ee9d583b888f934adbbe8d0/ring-0.16.20/build.rs:358:10
2023-10-10T17:25:14.4472692Z wasmcloud-deps>   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2023-10-10T17:25:14.4474937Z wasmcloud-deps> warning: build failed, waiting for other jobs to finish...

this won't work until our transitive Ring dependency is updated to 0.17

connorsmith256 pushed a commit to connorsmith256/wasmCloud that referenced this pull request Oct 17, 2023
@yordis
fix: resubscribing when lattice connection change
f93e3b7 
closes wasmCloud#741
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@rvolosatovs rvolosatovs reopened this Oct 18, 2023
@rvolosatovs rvolosatovs force-pushed the build/riscv64gc branch 8 times, most recently from 98055e4 to f29f441 Compare November 16, 2023 17:20
@rvolosatovs
build: add nixify cache
2e2c2f1 
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
@rvolosatovs
feat(wash): support RISCV64
334f733 
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
@rvolosatovs
ci: enable RISCV64 builds
543c2e5 
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
@rvolosatovs rvolosatovs marked this pull request as ready for review November 20, 2023 18:22
@rvolosatovs rvolosatovs requested review from a team as code owners November 20, 2023 18:22
@rvolosatovs rvolosatovs enabled auto-merge (rebase) November 20, 2023 18:23
vados-cosmonic
vados-cosmonic approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@vados-cosmonic vados-cosmonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rvolosatovs rvolosatovs merged commit 9b2fd4d into wasmCloud:main Nov 20, 2023
47 checks passed
@rvolosatovs rvolosatovs deleted the build/riscv64gc branch November 20, 2023 21:40
@rvolosatovs rvolosatovs mentioned this pull request Nov 21, 2023
Open
@rvolosatovs rvolosatovs mentioned this pull request Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brooksmtownsend brooksmtownsend brooksmtownsend approved these changes

@vados-cosmonic vados-cosmonic vados-cosmonic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add support for riscv64 to wash [FEATURE] add RISCV64 build
3 participants
@rvolosatovs @brooksmtownsend @vados-cosmonic