chore: move washboard to its own directory #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes please, until we have a release process |
connorsmith256
force-pushed
the
chore/split-washboard
branch
from
43dab62
to
0b579ee
Compare
rvolosatovs
previously approved these changes
Oct 19, 2023
vados-cosmonic
pushed a commit
to vados-cosmonic/wasmCloud
that referenced
this pull request
Oct 19, 2023
fix: specify version of wash-lib
|
On second thought, I'll leave this in draft until we've archived the wash repo. I don't want to make it more difficult to cherry-pick changes from there |
connorsmith256
force-pushed
the
chore/split-washboard
branch
from
0b579ee
to
6688b14
Compare
connorsmith256
force-pushed
the
chore/split-washboard
branch
from
6688b14
to
23dceed
Compare
This was referenced Oct 30, 2023
lachieh
requested changes
Oct 31, 2023
rvolosatovs
previously approved these changes
Oct 31, 2023
connorsmith256
force-pushed
the
chore/split-washboard
branch
from
23dceed
to
2cc4378
Compare
connorsmith256
requested review from
lachieh,
brooksmtownsend and
rvolosatovs
Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
connorsmith256
force-pushed
the
chore/split-washboard
branch
from
2cc4378
to
5292cbe
Compare
Closed
lachieh
approved these changes
Oct 31, 2023
brooksmtownsend
approved these changes
Oct 31, 2023
|
Looks like you forgot to update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This is the minimal amount of work to split the
washboarddirectory out ofwashinto its own top-level directoryThe washboard doesn't have any CI yet
@lachieh should I commit changes to
dist/?Testing
Manual Verification
cd washboard && make build-ui && cd -cd wash && cargo build./target/debug/wash up --nats-websocket-port 4001./target/debug/wash ui --experimental