Fix/drop prov rpc #774
Merged
Fix/drop prov rpc #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorsmith256
force-pushed
the
fix/drop-prov-rpc
branch
from
e6b656e
to
89f7497
Compare
This was referenced Oct 20, 2023
Merged
connorsmith256
force-pushed
the
fix/drop-prov-rpc
branch
from
89f7497
to
c566fb3
Compare
Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
connorsmith256
force-pushed
the
fix/drop-prov-rpc
branch
from
c566fb3
to
c623d04
Compare
rvolosatovs
approved these changes
Nov 15, 2023
thomastaylor312
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
Leaving in draft for now, since we should remove support from wash first: wasmCloud/wash#929The host supports separate
rpcandprov_rpcNATS connections. The intent was to separate untrusted providers from snooping on traffic they shouldn't have access to. However, in practice this doesn't work, since the host only sends a single NATS URL to the provider inHostDatata. The host has been sendingprov_rpc, but the host subscribes to RPC traffic onrpc, which means if two separate URLs/servers were used, providers and hosts wouldn't be able to communicate. Since this doesn't work today, let's just remove support for separate connections.Related Issues
Release Information
v0.80, since this is technically a breaking change (though I expect no users to be relying on it)
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification