Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to Wasmtime 14 and latest WIT #784

Merged
merged 2 commits into from
Oct 25, 2023
Merged

chore: update to Wasmtime 14 and latest WIT #784

merged 2 commits into from
Oct 25, 2023

Conversation

rvolosatovs
Copy link
Member

@rvolosatovs rvolosatovs commented Oct 23, 2023 •
edited

Feature or Problem

  • Remove compat feature from wasmcloud_actor (we don't actually need it)
  • Add resource support
  • Switch to upstream wasi-http (with no support for outgoing HTTP)
  • Add a test case for wasi-sockets making sure no socket can be bound to
  • Copy-paste WIT definitions from Wasmtime 14.0.1 (upstream packages are nowhere near being ready to use with this)
    • basically, assuming your FS layout complies with the old-school $GOPATH, this will mostly not mess up your wit/deps:
for d in wit/deps/*; do rm -rf $d && cp -Rv ~/src/github.com/bytecodealliance/wasmtime/crates/wasi/$d $d; done

Related Issues

Extracted from #748

Release Information

Consumer Impact

Testing

Built on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Tested on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Unit Test(s)

Acceptance or Integration

Manual Verification

cargo test

@rvolosatovs rvolosatovs force-pushed the update/wasmtime-14 branch 3 times, most recently from 5b22b6f to 33d53d5 Compare October 24, 2023 20:59
@rvolosatovs
chore: update to Wasmtime 14 and latest WIT
e72f4c3 
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
@rvolosatovs rvolosatovs marked this pull request as ready for review October 24, 2023 22:25
@rvolosatovs rvolosatovs requested review from a team as code owners October 24, 2023 22:25
@rvolosatovs rvolosatovs enabled auto-merge (rebase) October 24, 2023 22:38
@rvolosatovs
test: ensure no TCP/UDP socket can be bound to
02fcb94 
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
thomastaylor312
thomastaylor312 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@thomastaylor312 thomastaylor312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor non-blocking comment

tests/actors/rust/builtins-component-reactor/src/lib.rs Show resolved Hide resolved
@rvolosatovs rvolosatovs merged commit 66018a2 into wasmCloud:main Oct 25, 2023
23 checks passed
@rvolosatovs rvolosatovs deleted the update/wasmtime-14 branch October 25, 2023 07:08
@rvolosatovs rvolosatovs mentioned this pull request Oct 25, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorsmith256 connorsmith256 connorsmith256 approved these changes

@thomastaylor312 thomastaylor312 thomastaylor312 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rvolosatovs @connorsmith256 @thomastaylor312