Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(examples): remove local example #793

Merged

Conversation

vados-cosmonic
Copy link
Contributor

@vados-cosmonic vados-cosmonic commented Oct 25, 2023

Feature or Problem

As we're about to replace the examples in wasmcloud/wasmcloud with component-first providers and actors (in various languages), we should probably remove the current example that's there which uses the local transport.

It's arguable that the local transport should be removed entirely, but that's out of scope for this change.

This commit removes the local example, which is almost identical to the tests/local.rs, in favor of the coming examples.

Related Issues

Release Information

Consumer Impact

Testing

Built on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Tested on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Unit Test(s)

Acceptance or Integration

Manual Verification

@vados-cosmonic vados-cosmonic requested a review from a team as a code owner October 25, 2023 00:45
@vados-cosmonic vados-cosmonic requested a review from a team as a code owner October 25, 2023 00:45
rvolosatovs
rvolosatovs previously approved these changes Oct 25, 2023
As we're about to replace the examples in wasmcloud/wasmcloud with
component-first providers and actors (in various languages), we should
probably remove the current example that's there which uses the local transport.

It's arguable that the local transport should be removed entirely, but
that's out of scope for this change.

This commit removes the local example, which is almost identical to
the `tests/local.rs`, in favor of the coming examples.

Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
connorsmith256
connorsmith256 previously approved these changes Oct 25, 2023
@vados-cosmonic
Copy link
Contributor Author

vados-cosmonic commented Oct 25, 2023

@connorsmith256 can you please re-run tests (and approve/re-merge since I needed to resolve conflicts and rebase + squash?)?

Nix build failed with a transient error:


error:
       … while fetching the input 'github:NixOS/nixpkgs/nixpkgs-unstable'

       error: unable to download 'https://api.github.com/repos/NixOS/nixpkgs/commits/nixpkgs-unstable': HTTP error 422

       response body:

       {
         "message": "The request could not be processed because too many files changed",
         "documentation_url": "https://docs.github.com/rest/commits/commits#get-a-commit"

@connorsmith256 connorsmith256 merged commit e6e57ab into wasmCloud:main Oct 25, 2023
23 checks passed
@vados-cosmonic vados-cosmonic deleted the refactor/remove-local-example branch October 25, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants