fix: publish correct number actor events #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksmtownsend
force-pushed
the
fix/actor-started-number-events
branch
from
bb86d10
to
f21b15f
Compare
brooksmtownsend
changed the title
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
brooksmtownsend
force-pushed
the
fix/actor-started-number-events
branch
from
f21b15f
to
54cbd1f
Compare
brooksmtownsend
changed the title
connorsmith256
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR fixes a regression where we no longer published the correct number of
actor_startedandactor_stoppedevents in response to scaling an actor. This affects downstream consumers of the non-plural events when they are using thescalectl operation command.Because of the scenario where we may scale up or down, I refactored the event publishing code to be outside of the instantiate/uninstantiate function.
Related Issues
Regression introduced in #710
Release Information
v0.80.0
Consumer Impact
Testing
Built on platform(s)
Tested on platform(s)
Unit Test(s)
Acceptance or Integration
Manual Verification