feat: support specifying tags in actor config for use when signing #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vados-cosmonic
requested review from
autodidaddict,
brooksmtownsend,
thomastaylor312 and
mattwilkinsonn
as code owners
vados-cosmonic
force-pushed
the
feat/support-tags-in-actor-config
branch
from
55bed26
to
5d1f493
Compare
vados-cosmonic
force-pushed
the
feat/support-tags-in-actor-config
branch
from
5d1f493
to
3b04569
Compare
The signing process enabled by the wasmCloud ecosystem can confer tags on to generated artifacts. This helps in adding metadata to actors and other artifacts produced by wash. This commit adds the ability to specify tags in `wasmcloud.toml` to `wash`, so users can more easily tag generated & signed actors Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
vados-cosmonic
force-pushed
the
feat/support-tags-in-actor-config
branch
from
3b04569
to
18e88bd
Compare
yordis
pushed a commit
to yordis/wasmCloud
that referenced
this pull request
Oct 30, 2023
…-0.10.8 build(deps): Bump sha2 from 0.10.7 to 0.10.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
The signing process enabled by the wasmCloud ecosystem can confer tags on to generated artifacts. This helps in adding metadata to actors and other artifacts produced by wash.
This commit adds the ability to specify tags in
wasmcloud.tomltowash, so users can more easily tag generated & signed actorsRelated Issues
wasmCloud/wash#951
Release Information
Consumer Impact
Testing
Built on platform(s)
Tested on platform(s)
Unit Test(s)
Acceptance or Integration
Manual Verification