Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): fix parameter name #873

Merged
merged 1 commit into from
Oct 31, 2023
Merged

fix(ci): fix parameter name #873

merged 1 commit into from
Oct 31, 2023

Conversation

connorsmith256
Copy link
Contributor

Feature or Problem

dockerfile isn't a valid parameter name. I think we want file: https://github.com/wasmCloud/wasmCloud/actions/runs/6698978154

@connorsmith256
fix(ci): fix parameter name
a77f6e8 
Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
@connorsmith256 connorsmith256 requested a review from a team as a code owner October 30, 2023 23:08
@connorsmith256 connorsmith256 enabled auto-merge (rebase) October 30, 2023 23:45
aish-where-ya pushed a commit to aish-where-ya/wasmCloud that referenced this pull request Oct 31, 2023
@connorsmith256
Merge pull request wasmCloud#873 from connorsmith256/feat/get-all-inv…
3b58fc7 
…entories

feat: query all host inventories
rvolosatovs
rvolosatovs approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@rvolosatovs rvolosatovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect an error for specifying a nonexistent parameter 🤔

@connorsmith256 connorsmith256 merged commit 1759ac8 into wasmCloud:main Oct 31, 2023
25 checks passed
@connorsmith256 connorsmith256 deleted the fix/docker-arg branch October 31, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvolosatovs rvolosatovs rvolosatovs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@connorsmith256 @rvolosatovs