Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This updates the host to queue subscribe to the
linkdefs.*
andget.*
topics:get.*
(links, claims) topics can likewise be served by a single host, since clients (should) only listen for a single reply on this topicThis also disables the
handle_links
trace for now, since wadm currently makes too many requests for links, generating spammy tracesThis also disambiguates the
handle_message
function name tohandle_rpc_message
(handling incoming messages for actors) andhandle_ctl_message
(handling incoming messages for the host)The net effect of these changes should be a reduction in traces and more clear span names
Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification
I started 3 hosts with trace-level logging and issued various linkdef get/put/delete commands to the hosts, confirming a single host responded to each message and that all hosts updated their internal state