Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/queue subscribe #894

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

connorsmith256
Copy link
Contributor

Feature or Problem

This updates the host to queue subscribe to the linkdefs.* and get.* topics:

  • Link def gets and puts can be handled by a single host: the host simply proxies these requests into the LATTICEDATA KV bucket, and the data watcher thread will then receive a new message and update the host's in-memory cache
  • The get.* (links, claims) topics can likewise be served by a single host, since clients (should) only listen for a single reply on this topic

This also disables the handle_links trace for now, since wadm currently makes too many requests for links, generating spammy traces

This also disambiguates the handle_message function name to handle_rpc_message (handling incoming messages for actors) and handle_ctl_message (handling incoming messages for the host)

The net effect of these changes should be a reduction in traces and more clear span names

Related Issues

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

I started 3 hosts with trace-level logging and issued various linkdef get/put/delete commands to the hosts, confirming a single host responded to each message and that all hosts updated their internal state

Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
@connorsmith256 connorsmith256 requested a review from a team as a code owner November 1, 2023 20:07
@connorsmith256 connorsmith256 merged commit 2c77841 into wasmCloud:main Nov 1, 2023
25 checks passed
@connorsmith256 connorsmith256 deleted the fix/queue-subscribe branch November 1, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants