Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime): wasifill single-argument/return value functions with simple types #916

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

rvolosatovs
Copy link
Member

@rvolosatovs rvolosatovs commented Nov 3, 2023

Feature or Problem

  • Wasifill single-argument/return value functions with simple types encoded using msgpack
  • Switch wasmcloud:bus/lattice.target-interface to a real resource with custom interface support

Related Issues

bytecodealliance/wasmtime#7477 (I'm afraid we'll have to depend on a Git rev until this is backported to 14 (unlikely) - more likely we'd need #748 - i.e. wasmtime 15)

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

cargo test

@rvolosatovs rvolosatovs marked this pull request as ready for review November 3, 2023 17:24
@rvolosatovs rvolosatovs requested a review from a team as a code owner November 3, 2023 17:24
@rvolosatovs rvolosatovs enabled auto-merge (rebase) November 3, 2023 17:25
@rvolosatovs rvolosatovs force-pushed the feat/wasifills branch 2 times, most recently from 08a0582 to 04b294d Compare November 3, 2023 17:46
@rvolosatovs rvolosatovs changed the title feat: wasifill single-argument/return value functions with simple types feat(runtime): wasifill single-argument/return value functions with simple types Nov 3, 2023
Copy link
Contributor

@thomastaylor312 thomastaylor312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor follow up questions but nothing is a hard block

crates/runtime/src/actor/component/mod.rs Outdated Show resolved Hide resolved
crates/runtime/src/actor/component/mod.rs Outdated Show resolved Hide resolved
crates/runtime/src/actor/component/mod.rs Outdated Show resolved Hide resolved
crates/runtime/src/actor/component/mod.rs Outdated Show resolved Hide resolved
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
@rvolosatovs rvolosatovs force-pushed the feat/wasifills branch 3 times, most recently from dedca8c to 3fe2516 Compare November 7, 2023 11:06
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
@rvolosatovs rvolosatovs merged commit e128173 into wasmCloud:main Nov 7, 2023
30 checks passed
@rvolosatovs rvolosatovs deleted the feat/wasifills branch November 7, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants