feat(wash): download washboard assets from releases instead of embedding from source #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing from source Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
thomastaylor312
approved these changes
Nov 3, 2023
No, we can run through the washboard npm script with |
Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
lachieh
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This changes
wash uito download the washboard assets from a released version instead of embedding local files, which will enable publishing washThe version defaults to v0.1.0 for now, but can be specified with
--version:@lachieh do we need to allow overriding this behavior for local dev? Or should local dev always be done via
make run-ui?Related Issues
Resolves #875
Release Information
v0.22.0
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification
Built and ran locally, and confirmed I could serve the washboard UI