[BUG] wash app commands do not respect wash context #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x arg > context arg > $current_default context.lattice_prefix) Signed-off-by: Ahmed <ahmedtadde@gmail.com>
connorsmith256
requested changes
Nov 7, 2023
…_prefix parsing on app cmds Signed-off-by: Ahmed <ahmedtadde@gmail.com>
Signed-off-by: Ahmed <ahmedtadde@gmail.com>
Signed-off-by: Ahmed <ahmedtadde@gmail.com>
|
@ahmedtadde the latest changes look great. It looks like part of your new test is failing, but only on Windows. I suspect |
Signed-off-by: Ahmed <ahmedtadde@gmail.com>
connorsmith256
approved these changes
Nov 8, 2023
|
Filed the suspected windows bug: #966 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
When a context is set,
wash appcommands should respect that contextRelated Issues
#864
Release Information
wash-cli v0.22.0Consumer Impact
improved correctness and DX for
wash appcommands.Testing
Unit Test(s)
test_lattice_prefix_and_nats_client_from_cmd_opts