Actor termination candidates now filtered by optional annotations #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Hoffman <autodidaddict@users.noreply.github.com>
autodidaddict
requested review from
brooksmtownsend,
thomastaylor312 and
stevelr
as code owners
Signed-off-by: Kevin Hoffman <autodidaddict@users.noreply.github.com>
brooksmtownsend
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an annotation map is supplied to the stop actor control interface function (and thereby the
terminate_actorfunction), those annotations will be used to narrow the pool of candidate actors against which the stop operation works.For context,
wadmwill supply such annotations where one annotation contains the "appspec" label, a key that wadm uses to identify which resources belong to which applications.