Echo and KVcounter integration benchmark tests #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksmtownsend
changed the title
Would this be helpful? I.e. writing out benchmark results to a file and attaching it to a run as an artifact? https://github.com/actions/upload-artifact |
Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
brooksmtownsend
force-pushed
the
ci/moar-benchmark-tests
branch
from
d5465ad
to
cc9b0a6
Compare
brooksmtownsend
requested review from
autodidaddict,
thomastaylor312 and
stevelr
as code owners
Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
connorsmith256
approved these changes
Feb 28, 2023
thomastaylor312
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR aims to add benchmark integration tests for the echo and kvcounter sample actors so that we can compare performance across new features and bug fixes in the OTP host.
Release Information
nextreleaseConsumer Impact
The only impact this PR has is that it might slow down some of our integration tests by about a minute since they will be benchmarking.
Testing
Tested on platform(s)
Unit Test(s)
Modified echo, added echo_wasi benchmark
Acceptance or Integration
Ideally, I'd like to include a way to upload benchmark results so we can compare over time.
Manual Verification
I'm just running this locally:
MIX_ENV=test mix test test/host_core/benchmark/echo_test.exs