Bumping the version of wascap to the newest #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Hoffman <autodidaddict@users.noreply.github.com>
autodidaddict
requested review from
brooksmtownsend,
thomastaylor312 and
stevelr
as code owners
brooksmtownsend
approved these changes
Mar 24, 2023
There was a problem hiding this comment.
Did this in #583 but I'll rebase 😉 Better to have it in a separate PR anyways
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
Version 0.10.0 of wascap doesn't properly validate the hashes of modules signed with wascap versions 0.9.0 through 0.10.0. The 0.10.1 version fixes this
Related Issues
N/A
Release Information
Next (0.62.0)
Consumer Impact
Without this, wasmCloud host will reject wasm modules signed by 0.9.0/0.10.0 of wascap, breaking functionality
Testing
Built on platform(s)
Tested on platform(s)
Unit Test(s)
Acceptance or Integration
N/A
Manual Verification
Tested this manually with a number of different modules, including old ones and ones signed with 0.9.0