Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for builtin providers and deferring builtin logging to the OTP host #592

Merged
merged 4 commits into from
Mar 28, 2023

Conversation

autodidaddict
Copy link
Member

Feature or Problem

Version 0.62 does not currently emit any information when actors log using the builtin capability provider. This adds that support back in a way that is compatible with previous hosts.

Related Issues

This supercedes @rvolosatovs 's PR #591 because, in all honesty, I couldn't figure out how to make a PR off of his PR and didn't have rights to force push to his PR

Release Information

0.62

Consumer Impact

All deployments of wasmCloud relying on actor log emissions with or without structured host logging.

Testing

There is an explicit actor test for performing logging and random number generation to exercise the builtins

Built on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Tested on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Unit Test(s)

test/host_core/actors_test.exs:639 is the test that exercises builtins (including logging). This test passes and produces the expected output in stdout.

Acceptance or Integration

Manual Verification

Manually verified this works as well as unit tested using the "rando logger" actor.

Log emissions look as follows:

14:21:41.872 [debug] actor_id=MCLOGOFFRJ4WK5XC6Z6WM7A3SAVHPHKDAVG6OMZVOOC6RQCN5IOKPTQL [MCLOGOFFRJ4WK5XC6Z6WM7A3SAVHPHKDAVG6OMZVOOC6RQCN5IOKPTQL] a debug!
14:21:41.872 [info] actor_id=MCLOGOFFRJ4WK5XC6Z6WM7A3SAVHPHKDAVG6OMZVOOC6RQCN5IOKPTQL [MCLOGOFFRJ4WK5XC6Z6WM7A3SAVHPHKDAVG6OMZVOOC6RQCN5IOKPTQL] an info!
14:21:41.872 [warning] actor_id=MCLOGOFFRJ4WK5XC6Z6WM7A3SAVHPHKDAVG6OMZVOOC6RQCN5IOKPTQL [MCLOGOFFRJ4WK5XC6Z6WM7A3SAVHPHKDAVG6OMZVOOC6RQCN5IOKPTQL] a warn!
14:21:41.872 [error] actor_id=MCLOGOFFRJ4WK5XC6Z6WM7A3SAVHPHKDAVG6OMZVOOC6RQCN5IOKPTQL [MCLOGOFFRJ4WK5XC6Z6WM7A3SAVHPHKDAVG6OMZVOOC6RQCN5IOKPTQL] an error!
14:21:41.872 [info] actor_id=MCLOGOFFRJ4WK5XC6Z6WM7A3SAVHPHKDAVG6OMZVOOC6RQCN5IOKPTQL [MCLOGOFFRJ4WK5XC6Z6WM7A3SAVHPHKDAVG6OMZVOOC6RQCN5IOKPTQL] a manual info!

rvolosatovs and others added 2 commits March 27, 2023 17:34
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Kevin Hoffman <autodidaddict@users.noreply.github.com>
Signed-off-by: Kevin Hoffman <autodidaddict@users.noreply.github.com>
@autodidaddict autodidaddict changed the title Feat/host builtins Adding support for builtin providers and deferring builtin logging to the OTP host Mar 27, 2023
@rvolosatovs rvolosatovs mentioned this pull request Mar 27, 2023
10 tasks
Signed-off-by: Kevin Hoffman <autodidaddict@users.noreply.github.com>
@autodidaddict autodidaddict merged commit 6e3caca into main Mar 28, 2023
@autodidaddict autodidaddict deleted the feat/host-builtins branch March 28, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants