Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos static builds via bakeware #593

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

pgray
Copy link
Contributor

@pgray pgray commented Mar 28, 2023

Feature or Problem

add a build script that will run on macOS and generate a statically linked openssl/erlang/elixir

Related Issues

#572

Release Information

next

Consumer Impact

will allow us to generate a mac release without depending on openssl via brew

Testing

manually run on macOS aarch64

Built on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Tested on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Unit Test(s)

n/a

Acceptance or Integration

n/a

Manual Verification

had some folks run the bakeware file and it seemed to work

@pgray pgray changed the title Pgray macos static macos static builds via bakeware Mar 28, 2023
Copy link
Member

@brooksmtownsend brooksmtownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, only request is to include some kind of make target or instructions for how we should run this to generate a static build 😄

@pgray pgray force-pushed the pgray-macos-static branch 8 times, most recently from 83a7fd2 to 9aed91e Compare April 4, 2023 04:16
@brooksmtownsend
Copy link
Member

@pgray I see some churn and am just letting ya test, please @ me once you're ready for a full review <3

@pgray
Copy link
Contributor Author

pgray commented Apr 7, 2023

looks like the job is working.
https://github.com/pgray/wasmcloud-otp/actions/runs/4633845745

i just don't have an Intel Mac to test the artifact

Copy link
Member

@brooksmtownsend brooksmtownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big question before I approve

.github/workflows/release.yml Show resolved Hide resolved
this avoids erlang dynamically linking to openssl
and should fix on macOS for anyone missing dev tools

Signed-off-by: pgray <patrick@cosmonic.com>
@brooksmtownsend brooksmtownsend merged commit b553e76 into wasmCloud:main Apr 24, 2023
12 checks passed
@pgray pgray deleted the pgray-macos-static branch April 24, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants