Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove cross-rs for native builds #597

Conversation

vados-cosmonic
Copy link
Contributor

@vados-cosmonic vados-cosmonic commented Mar 30, 2023

Feature or Problem

This PR removes cross-rs for cross-platform builds, falling back to per-platform builds.

This was necessary because the .dlls that cross-rs was building seemed to not be correct/working on Windows

Related Issues

#566
wasmCloud/wash#494

Release Information

next

Consumer Impact

Windows users will be able to use published releases

Testing

Built on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Tested on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Unit Test(s)

N/A

Acceptance or Integration

N/A

Manual Verification

Build was run manually and in CI, then tested on both windows and linux

- note: this commit removes cross-rs

Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
@vados-cosmonic vados-cosmonic changed the title Fix/remove cross rs for native builds fix: remove cross-rs for native builds Mar 30, 2023
Copy link
Member

@brooksmtownsend brooksmtownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍🏻

@vados-cosmonic
Copy link
Contributor Author

Hey @brooksmtownsend thanks! Testing on apple to make sure that the build works properly is the only thing left, once we have all the artifacts from this PR filled out I'll run the artifacts locally on my my mac so I can cover the last 3 platforms

I'm assuming that running with the x86 compat layer on Mac is fine here...

Maybe I should just add a step that does a basic self-test into the runners, this would save us having to do it ourselves.

@vados-cosmonic
Copy link
Contributor Author

Considering this PR does not change the actual code, or even build & test actions... I'm going to assume this test is a flake:


  1) test can get linkdefs (HostCore.E2E.ControlInterfaceTest)
Error:      test/e2e/controlinterface_test.exs:48
     ** (MatchError) no match of right hand side value: {:error, :no_responders}
     code: {:ok, %{body: body}} =
     stacktrace:
       test/e2e/controlinterface_test.exs:64: (test)

@brooksmtownsend brooksmtownsend merged commit d13b509 into wasmCloud:main Mar 30, 2023
@vados-cosmonic vados-cosmonic deleted the fix/remove-cross-rs-for-native-builds branch March 30, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants