BREAKING: pass log_level in HostData #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
|
After talking with @thomastaylor312, he agreed that renaming to |
|
@connorsmith256 I like the idea of using |
The new config value applies to structured and unstructured logging. To maintain backwards-compatibility, the old environment variable is mapped to the new field Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
connorsmith256
force-pushed
the
feat/provider-log-level
branch
from
99d8a89
to
56ffe71
Compare
connorsmith256
requested review from
autodidaddict,
brooksmtownsend and
thomastaylor312
as code owners
connorsmith256
changed the title
brooksmtownsend
previously approved these changes
Apr 14, 2023
Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
brooksmtownsend
previously approved these changes
Apr 14, 2023
brooksmtownsend
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This passes
log_levelto providers. See wasmCloud/weld#148 for contextRelated Issues
wasmCloud/weld#148
Release Information
v0.63.0, since this is technically a breaking change. See below.
Consumer Impact
See the testing section of wasmCloud/weld#148. Notice that after this change,
RUST_LOGis ignored.Note: I find it odd that the source field is calledstructured_log_level, and that Elixir logging is controlled via mix environment without structured logging enabled. I propose we make this a breaking change: rename this field to justlog_level, proxy it through to providers, and also respect it when structured logging is not enabledUpdate: we decided the following:
WASMCLOUD_STRUCTURED_LOG_LEVELis now deprecated, but will continue to be parsedWASMCLOUD_LOG_LEVELnow controls logging for structured and unstructured logsTesting
Manual Verification
See testing section of wasmCloud/weld#148