Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add annotations to actor_stopped and provider_stopped events #611

Merged

Conversation

connorsmith256
Copy link
Contributor

Feature or Problem

This adds annotations to the actor_stopped and provider_stopped events

Related Issues

Resolves #609

Release Information

Next

Consumer Impact

wadm can read annotations off stop events now

Testing

Manual Verification

Notice both started and stopped events have annotations on them:

{"data":{"annotations":{"foo":"bar"},"api_version":"n/a","claims":{"call_alias":null,"caps":["wasmcloud:httpserver"],"expires_human":"never","issuer":"ACOJJN6WUP4ODD75XEBKKTCCUJJCY5ZKQ56XVKYK4BEJWGVAOOQHZMCW","name":"Echo","not_before_human":"immediately","revision":4,"tags":[],"version":"0.3.4"},"image_ref":"wasmcloud.azurecr.io/echo:0.3.4","instance_id":"a7bf8b1a-5162-450d-b28c-90ed5fb7b92b","public_key":"MBCFOPM6JW2APJLXJD3Z5O4CN7CPYJ2B4FTKLJUR5YR5MITIU7HD3WD5"},"datacontenttype":"application/json","id":"88410ca3-ac67-48c8-9517-b923e1d9b4be","source":"NDDVDHNK5CALTETFF3LXLU67MYWENIR2CRZXPIKF3K6GRFFUOXMXSPFW","specversion":"1.0","time":"2023-04-10T23:36:15.711366Z","type":"com.wasmcloud.lattice.actor_started"}

{"data":{"annotations":{"foo":"bar"},"claims":{"expires_human":"never","issuer":"ACOJJN6WUP4ODD75XEBKKTCCUJJCY5ZKQ56XVKYK4BEJWGVAOOQHZMCW","name":"HTTP Server","not_before_human":"immediately","tags":null,"version":"0.17.0"},"contract_id":"wasmcloud:httpserver","image_ref":"wasmcloud.azurecr.io/httpserver:0.17.0","instance_id":"e8a6e19f-451b-4b09-b4e8-cf3fc6d36ae9","link_name":"default","public_key":"VAG3QITQQ2ODAOWB5TTQSDJ53XK3SHBEIFNK4AYJ5RKAX2UNSCAPHA5M"},"datacontenttype":"application/json","id":"7a716481-2bf3-4e6c-9a2b-8dad911b698d","source":"NDDVDHNK5CALTETFF3LXLU67MYWENIR2CRZXPIKF3K6GRFFUOXMXSPFW","specversion":"1.0","time":"2023-04-10T23:36:20.930599Z","type":"com.wasmcloud.lattice.provider_started"}

{"data":{"annotations":{"foo":"bar"},"instance_id":"a7bf8b1a-5162-450d-b28c-90ed5fb7b92b","public_key":"MBCFOPM6JW2APJLXJD3Z5O4CN7CPYJ2B4FTKLJUR5YR5MITIU7HD3WD5"},"datacontenttype":"application/json","id":"cd74c99e-79f3-46c4-980d-d38fe02cb297","source":"NDDVDHNK5CALTETFF3LXLU67MYWENIR2CRZXPIKF3K6GRFFUOXMXSPFW","specversion":"1.0","time":"2023-04-10T23:36:28.519520Z","type":"com.wasmcloud.lattice.actor_stopped"}

{"data":{"annotaions":{"foo":"bar"},"contract_id":"wasmcloud:httpserver","instance_id":"e8a6e19f-451b-4b09-b4e8-cf3fc6d36ae9","link_name":"default","public_key":"VAG3QITQQ2ODAOWB5TTQSDJ53XK3SHBEIFNK4AYJ5RKAX2UNSCAPHA5M","reason":"normal"},"datacontenttype":"application/json","id":"7751b426-e6fa-4672-8f4d-37f19cbe10c9","source":"NDDVDHNK5CALTETFF3LXLU67MYWENIR2CRZXPIKF3K6GRFFUOXMXSPFW","specversion":"1.0","time":"2023-04-10T23:36:29.420499Z","type":"com.wasmcloud.lattice.provider_stopped"}

Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
@connorsmith256 connorsmith256 merged commit 2e3f1de into wasmCloud:main Apr 11, 2023
11 checks passed
@connorsmith256 connorsmith256 deleted the fix/missing-annotations branch April 11, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] All actor and provider events should have annotations
2 participants