Added actors started and actors stopped events #617
Conversation
brooksmtownsend
requested review from
autodidaddict and
thomastaylor312
as code owners
|
Mac runners appear to be slow this morning, may be related to testing in #616. Tests all pass well locally /shrug |
Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
brooksmtownsend
force-pushed
the
feat/actors-started-stopped
branch
from
76c4506
to
2afd300
Compare
There was a problem hiding this comment.
My only real comment on this is that it feels like we're cluttering things by shuffling the lattice prefix around from call to call even though it's in state ... but I've been in this pit of despair before and know how it gets messy as soon as you leave the GenServer bounds.
Yeah I agree with you around passing the prefix around. My pit of despair is just like, if I fail to look up the host for some reason that means that I can’t even publish the event back on the same lattice prefix that I just received a request on? |
Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
|
@connorsmith256 fixed to not need to pass the prefix around everywhere |
|
Tests should pass they are just getting an old version of |
Feature or Problem
This PR adds three new events to the ActorSupervisor:
actors_started,actors_start_failed, andactors_stopped. These events are published once after control interface requests to start/stop actors, once they finish, along with the total count started/stopped.Related Issues
No issue created, but this will allow
wadmto be a lot smarter in terms of knowing when a request to start/stop an actor actually completes.Release Information
v0.63.0Consumer Impact
These three events will be added, so consumers of the event stream will need to consider these if they subscribe to all events. As I'm writing this, I realize that I need to update the wasmCloud dashboard to ignore these.
Testing
Built on platform(s)
Tested on platform(s)
Unit Test(s)
Acceptance or Integration
Manual Verification
Tested to ensure these events publish properly and contain the proper information.