Allow port configuration, refactor start actor modal #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksmtownsend
force-pushed
the
ahoy-matey-open-up-the-ports
branch
from
907ca96
to
b4abaae
Compare
some actor modal cleanup format remove unused template quick refactor of start_actor_file signature
brooksmtownsend
force-pushed
the
ahoy-matey-open-up-the-ports
branch
from
b4abaae
to
28afd42
Compare
brooksmtownsend
commented
Jun 28, 2021
Comment on lines
167
to
173
| /** | ||
| * For some reason, stopping the execution of this file here makes the charts load correctly. | ||
| * Until we figure that out, leave this in. | ||
| * Thanks, JavaScript. | ||
| */ | ||
| null.ignoreThisError No newline at end of file | ||
| // /** | ||
| // * For some reason, stopping the execution of this file here makes the charts load correctly. | ||
| // * Until we figure that out, leave this in. | ||
| // * Thanks, JavaScript. | ||
| // */ | ||
| // null.ignoreThisError |
There was a problem hiding this comment.
As fun as this hack was, it does break the live view reloading, so the charts are going to have to be less impressive for a short time. They still render, just in a way that seems a little incorrect, so we can open up an issue to address that once we tackle #45
autodidaddict
requested changes
Jun 28, 2021
wasmcloud_host/lib/wasmcloud_host_web/live/start_actor_component.ex
Outdated
Show resolved
Hide resolved
brooksmtownsend
force-pushed
the
ahoy-matey-open-up-the-ports
branch
from
07ab10a
to
ef8186c
Compare
autodidaddict
requested changes
Jun 29, 2021
autodidaddict
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started as just a port configuration PR, but with some more UI changes with actors I figured I'd give refactoring the modal a try.
Along with port configuration, this PR also shows the appropriate host ID in the actor table, and the new "homepage" supposed to be the mockup for the full lattice view. In subsequent PRs, the lattice view will show a list of hosts that can be further inspected for only the resources (actors, providers) running on that specific host.
What I'd love feedback on is the code for the start actor component, how it's laid out in the page_live template, and how it looks when being used. Refactoring to live components makes it so that the modal disappears and only the table re-renders on the page, instead of a full POST request + page reload. I'd like to do the same thing to the define-link modal and the start providers modals, but I'd like some feedback before putting in the effort (and potentially mistakes) on those.