Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize annotations to compute spread requirements #78

Closed
brooksmtownsend opened this issue Apr 10, 2023 · 1 comment
Closed

Utilize annotations to compute spread requirements #78

brooksmtownsend opened this issue Apr 10, 2023 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@brooksmtownsend
Copy link
Member

While implementing #75, I realized that we aren't using annotations to mark actors that are managed by wadm. In addition to being managed by wadm, we'll also want to note the specific Spread that the annotation is using so that we can manage conflicting actor spreads.

Until this is complete, the ActorSpreadScaler as implemented in #75 will not be able to properly handle multiple spreads that match to the same host and it's recommended to keep spread requirements as specific as possible.

@brooksmtownsend brooksmtownsend added the help wanted Extra attention is needed label Apr 10, 2023
@brooksmtownsend
Copy link
Member Author

That's what I get for missing a review, looks like #76 adds annotation support. Will retrofit #75 to work with these changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant