Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle semaphore compilation / dtrace on linux #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

viraptor
Copy link

@viraptor viraptor commented Sep 3, 2021

I'm not sure exactly what the differences are between the system where this was tested and mine, I ran into the problem described in issue #1 .
The build failed first because of an -arch dtrace argument not available on my system (comes from systemtap 4.5). This was made an optional argument (default off).
Then it failed because of the semaphore file not being linked in. This was solved by adding an option to either compile without the semaphore object file (original behaviour, default), or to explicitly generate it (option).

If this doesn't play well with other systems this library was tested on, I'm happy to put some cfg guards around the functionality.

Fixes #1

@viraptor
Copy link
Author

viraptor commented Sep 3, 2021

Not sure if this is monitored, so pinging @Hywan

@viniciusd
Copy link

Does this fix look acceptable @Hywan?

I am having the same issue described at #1

@Hywan
Copy link
Contributor

Hywan commented Feb 28, 2022

I'm no longer working for Wasmer. You should ping @syrusakbary for that.

@viniciusd
Copy link

I'm no longer working for Wasmer. You should ping @syrusakbary for that.

Thanks for sharing! Wish you all the best in your new path

@No9
Copy link

No9 commented Jan 8, 2023

@viniciusd Thanks for putting together this patch.

@syrusakbary This patch works as expected and I would like to add to the docs to illustrate the linux eBPF scenario wtih tplist and bpftrace syntax.

Would it be possible to land this?

@viniciusd
Copy link

@viniciusd Thanks for putting together this patch.

@syrusakbary This patch works as expected and I would like to add to the docs to illustrate the linux eBPF scenario wtih tplist and bpftrace syntax.

Would it be possible to land this?

I wish I were responsible for the changes, but I cannot take @viraptor's credits. Either way, looking forward to having it merged (and thanks @viraptor)

@No9
Copy link

No9 commented Jan 8, 2023

Sincere Apologies @viraptor
I was fooled by the autocomplete.
Thanks @viniciusd for the correction

@Hywan Hywan mentioned this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

example fails to compile on ubuntu / rustc 1.53.0
4 participants