Remove unnecessary heap allocations and calls to C. #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
added
🎉 enhancement
Hywan
approved these changes
Feb 19, 2020
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 19, 2020
118: Remove unnecessary heap allocations and calls to C. r=Hywan a=koponen-styra Instead of allocating the function name and function parameter/return value holders for each function invocation, pre-allocate them. This is possible because invocations occur sequentially (in presence of no threading). This both reduces GC pressure and removes two cgo calls. Co-authored-by: Teemu Koponen <koponen@styra.com>
Build failed
|
|
Hmm, "just test" passes locally on my ubuntu. I tried to access the details from bors, but it merely says permission denied. |
|
I think bors failed because some Github permissions. Let's try again bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 19, 2020
118: Remove unnecessary heap allocations and calls to C. r=syrusakbary a=koponen-styra Instead of allocating the function name and function parameter/return value holders for each function invocation, pre-allocate them. This is possible because invocations occur sequentially (in presence of no threading). This both reduces GC pressure and removes two cgo calls. Co-authored-by: Teemu Koponen <koponen@styra.com>
Build failed
|
|
The error seem to be in the test bazel build: This is unrelated to the changes on this PR. Will try to fix it in master upstream and then we can just update this PR with the latest master :)
|
|
@koponen-styra if you rebase your PR with the latest master, the issue should be fixed (via 351f772 ) |
Instead of allocating the function name and function parameter/return value holders for each function invocation, pre-allocate them. This is possible because invocations occur sequentially (in presence of no threading). This both reduces GC pressure and removes two cgo calls.
koponen-styra
force-pushed
the
reduce-heap-allocations-and-cgo-calls
branch
from
03737cf
to
b297eb6
Compare
|
bors r+ |
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of allocating the function name and function parameter/return
value holders for each function invocation, pre-allocate them. This is
possible because invocations occur sequentially (in presence of no
threading).
This both reduces GC pressure and removes two cgo calls.