Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(config) Use parameterized tests to check all configurations #206

Merged
merged 4 commits into from Feb 18, 2021

Conversation

Hywan
Copy link
Contributor

@Hywan Hywan commented Feb 16, 2021

This patch updates config_test.go to better test all combinations between compilers and engines and platforms and architectures

The Singlepass compiler is missing for the moment, since we are waiting on #204 to get merged before.

@Hywan Hywan added 🎉 enhancement New feature or request 📦 component-extension About the Go extension 🧪 tests I love tests labels Feb 16, 2021
@Hywan Hywan requested a review from jubianchi February 16, 2021 13:23
@Hywan Hywan self-assigned this Feb 16, 2021
@Hywan Hywan added this to 🌱 In progress in Kanban via automation Feb 16, 2021
@Hywan
Copy link
Contributor Author

Hywan commented Feb 18, 2021

bors try

bors bot added a commit that referenced this pull request Feb 18, 2021
@Hywan
Copy link
Contributor Author

Hywan commented Feb 18, 2021

On linux/amd64 (https://github.com/wasmerio/wasmer-go/runs/1928465505#step:6:16):

--- PASS: TestConfig_AllCombinations (0.01s)
--- PASS: TestConfig_AllCombinations/compiler=Cranelift,_engine=JIT (0.00s)
--- PASS: TestConfig_AllCombinations/compiler=Cranelift,_engine=Native (0.01s)
--- PASS: TestConfig_AllCombinations/compiler=Singlepass,_engine=JIT (0.00s)

On darwin/amd64 (https://github.com/wasmerio/wasmer-go/runs/1928465585#step:6:16):

--- PASS: TestConfig_AllCombinations (1.85s)
--- PASS: TestConfig_AllCombinations/compiler=Cranelift,_engine=JIT (0.00s)
--- PASS: TestConfig_AllCombinations/compiler=Cranelift,_engine=Native (1.85s)
--- PASS: TestConfig_AllCombinations/compiler=Singlepass,_engine=JIT (0.00s)

Singlepass works :-). Let's merge it!

@Hywan Hywan merged commit 9ea145a into wasmerio:master Feb 18, 2021
Kanban automation moved this from 🌱 In progress to 🎉 Done Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 component-extension About the Go extension 🎉 enhancement New feature or request 🧪 tests I love tests
Projects
Kanban
  
🎉 Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant