feat(import) Support instance context API #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New `InstanceContext` API so that imported function can access the instance memory for example.
Hywan
added
🎉 enhancement
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 4, 2019
26: feat(import) Support instance context API r=Hywan a=Hywan Partially address #23. Ping @YaronWittenstein This PR brings an `InstanceContext` API: 1. From an imported function, call `IntoInstanceContext(context)` to cast the `unsafe.Pointer` into an `InstanceContext`, 2. Now, call the `Memory` method to get the instance context, 3. Use the `Memory.Data` method to read or write memor data. Co-authored-by: Ivan Enderlin <ivan.enderlin@hoa-project.net>
|
@Hywan you're the man!! |
Build succeeded |
This was referenced Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially address #23.
Ping @YaronWittenstein
This PR brings an
InstanceContextAPI:IntoInstanceContext(context)to cast theunsafe.Pointerinto anInstanceContext,Memorymethod to get the instance context,Memory.Datamethod to read or write memor data.