feat(import) Add Imports.Namespace to set the current import namespace
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace.
Basically, this patch allows to define imported function in any
namepace. The `Imports.Namespace` sets the current namespce for the
next defined imported functions:
```go
wasm.NewImports().Namespace("ns").Append("f", f, C.f)
```
By default, the namespace is `env`, so both statements are identical:
```go
wasm.NewImports().Namespace("env").Append(…)
wasm.NewImports().Append(…)
```
To register imported functions in different namespaces, one writes:
```go
wasm.NewImports().Namespace("ns1").Append(…).Append(…).Namespace("ns2").Append(…).Append(…)…
```
Hywan
added
🎉 enhancement
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 4, 2019
29: feat(import) Add `Imports.Namespace` to set the current import namespace r=Hywan a=Hywan Fix #25. Basically, this patch allows to define imported function in any namepace. The `Imports.Namespace` sets the current namespce for the next defined imported functions: ```go wasm.NewImports().Namespace("ns").Append("f", f, C.f) ``` By default, the namespace is `env`, so both statements are identical: ```go wasm.NewImports().Namespace("env").Append(…) wasm.NewImports().Append(…) ``` To register imported functions in different namespaces, one writes: ```go wasm.NewImports().Namespace("ns1").Append(…).Append(…).Namespace("ns2").Append(…).Append(…)… ``` Co-authored-by: Ivan Enderlin <ivan.enderlin@hoa-project.net>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #25.
Basically, this patch allows to define imported function in any
namepace. The
Imports.Namespacesets the current namespce for thenext defined imported functions:
By default, the namespace is
env, so both statements are identical:To register imported functions in different namespaces, one writes: