Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(module) Support import descriptors #38

Merged
merged 3 commits into from
Jun 7, 2019
Merged

feat(module) Support import descriptors #38

merged 3 commits into from
Jun 7, 2019

Conversation

Hywan
Copy link
Contributor

@Hywan Hywan commented Jun 7, 2019

Example:

var module, _ = wasm.Compile(bytes)

assert.Equal(…, "log_message", module.Imports[0].Name)
assert.Equal(…, "env", module.Imports[0].Namespace)

Hywan added 3 commits June 7, 2019 15:52
@Hywan
feat(module) Support import descriptors.
55245ab 
This patch adds the `ImportDescriptor` structure, renames `ExportKind`
to `ImportExportKind`, and adds the `Module.Imports` field, to
represent import descriptors.
@Hywan
test(module) Test Module.Imports.
da6eddf
@Hywan
doc(module) Document ImportDescriptor.
b41eddb
@Hywan Hywan added 🎉 enhancement New feature or request 📦 component-extension About the Go extension 📚 documentation Do you like to read? 🧪 tests I love tests labels Jun 7, 2019
@Hywan Hywan self-assigned this Jun 7, 2019
@Hywan
Copy link
Contributor Author

Hywan commented Jun 7, 2019

bors r+

bors bot added a commit that referenced this pull request Jun 7, 2019
@bors @Hywan
Merge #38
b212e98 
38: feat(module) Support import descriptors r=Hywan a=Hywan

Example:

```go
var module, _ = wasm.Compile(bytes)

assert.Equal(…, "log_message", module.Imports[0].Name)
assert.Equal(…, "env", module.Imports[0].Namespace)
```

Co-authored-by: Ivan Enderlin <ivan.enderlin@hoa-project.net>
@bors
Copy link
Contributor

bors bot commented Jun 7, 2019

Build succeeded

@bors bors bot merged commit b41eddb into wasmerio:master Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Hywan Hywan

Labels
📦 component-extension About the Go extension 📚 documentation Do you like to read? 🎉 enhancement New feature or request 🧪 tests I love tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Hywan