Access a WASIX instance's filesystem #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rve the wasm types polyfill
…put from Web Workers can be captured
|
⏱ Workflow Timer ⏱ Make sure you keep an eye on build times! The goal is to keep CI times under 10 minutes so developers can maintain a fast edit-compile-test cycle.
🤖 Beep. Boop. I'm a bot. If you find any issues, please report them to https://github.com/Michael-F-Bryan/workflow-timer. |
syrusakbary
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to mount directories and access the filesystem of a running WASIX instance.
Instead of creating a single
FileSystemclass, I've set things up so you need to pass in a dictionary of mountedDirectoryobjects. Most packages will include their own volumes, so allowing users to pass in a singleFileSystemclass which represents the WASIX instance's entire file system when spawning instances will make it really easy to shoot themselves in the foot by clobbering something important (see wasmerio/wasmer#4248).Users are given the ability to create either an empty
Directory(wrapper aroundTmpFileSystem) via its constructor or leverage the browser's File System API.