Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmer-pack-testing wasn't running "yarn jest" on MacOS/Linux #125

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

Michael-F-Bryan
Copy link
Contributor

@Michael-F-Bryan Michael-F-Bryan commented Mar 2, 2023

Description

This updates the way we invoke yarn to run the equivalent of sh -c "yarn jest" instead of sh -c "yarn" "jest". The latter version seems to be equivalent to a plain sh -c "yarn", which means every time we try to run yarn with a sub-command (to invoke tests, initialize package.json, add a dependency to package.json, etc.) we were just installing dependencies.

I'm guessing we originally missed this because cmd.exe /c "yarn" "jest" works on Windows (which is what @dynamite-bud used when implementing #120), and Wasmer Pack's CI was happy because running yarn by itself a bunch of times won't fail.

Context

When @dynamite-bud added JavaScript tests to his wasmerio/rustfft package (wasmerio/rustfft#8), he noticed that none of the Jest tests were being run.

Checklist

@Michael-F-Bryan Michael-F-Bryan marked this pull request as ready for review March 2, 2023 13:59
@Michael-F-Bryan Michael-F-Bryan changed the title Testing fixes wasmer-pack-testing wasn't running "yarn jest" on MacOS/Linux Mar 2, 2023
Copy link
Contributor

@dynamite-bud dynamite-bud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants