-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasmer-pack-testing wasn't running "yarn jest" on MacOS/Linux #125
Open
Michael-F-Bryan
wants to merge
20
commits into
master
Choose a base branch
from
testing-fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-F-Bryan
changed the title
Testing fixes
wasmer-pack-testing wasn't running "yarn jest" on MacOS/Linux
Mar 2, 2023
dynamite-bud
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the way we invoke
yarn
to run the equivalent ofsh -c "yarn jest"
instead ofsh -c "yarn" "jest"
. The latter version seems to be equivalent to a plainsh -c "yarn"
, which means every time we try to runyarn
with a sub-command (to invoke tests, initializepackage.json
, add a dependency topackage.json
, etc.) we were just installing dependencies.I'm guessing we originally missed this because
cmd.exe /c "yarn" "jest"
works on Windows (which is what @dynamite-bud used when implementing #120), and Wasmer Pack's CI was happy because runningyarn
by itself a bunch of times won't fail.Context
When @dynamite-bud added JavaScript tests to his
wasmerio/rustfft
package (wasmerio/rustfft#8), he noticed that none of the Jest tests were being run.Checklist
CHANGELOG.md