Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: (cargo serde example) #61

Closed
wants to merge 1 commit into from
Closed

Conversation

mrceperka
Copy link

Example that uses Serde as a Rust dependency and returns serialized (JSON) struct.

@Hywan Hywan self-assigned this May 21, 2019
@Hywan Hywan added 📚 documentation Do you like to read? 🎉 enhancement New feature or request labels May 21, 2019
@Hywan
Copy link
Contributor

Hywan commented May 21, 2019

Hello, thanks for the new example! I'm happy you've been able to use Rust with Serde to encode your data with JSON, and decode them in PHP.

However, I don't see how it illustrates php-ext-wasm. The API usage is almost identical to the greet example. Your example shows the pre-Wasm part (in this case, the Rust part), and not the PHP part (which is the goal of the examples/ directory: it shows how to use the PHP Wasm extension). Wasm is not tied to Rust only, but to any language that can compile to Wasm, so adding an illustration with Rust isn't clear for me. It has its place as a blog post though!

What do you think?

@mrceperka
Copy link
Author

I don't think that I am able to write a blog post. You can of course reuse this material and PR.

Also, you are right, this does not illustrate new usage of php-ext-wasm.

Feel free to close this PR.
Thanks for you reaction.

👋

@Hywan
Copy link
Contributor

Hywan commented May 22, 2019

😃

@Hywan Hywan closed this May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Do you like to read? 🎉 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants