feat(instance) Introduce the wasm_instance structure
#69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thus, it simplifies the `WasmArrayBuffer` internal structure, where we can remove the exports pointer.
Hywan
added
🎉 enhancement
|
bors try |
tryBuild succeeded |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 10, 2019
69: feat(instance) Introduce the `wasm_instance` structure r=Hywan a=Hywan This PR introduces a `wasm_instance` structure. It holds a `wasmer_instance_t` pointer and a `wasmer_exports_t` pointer. Thus, it simplifies the `WasmArrayBuffer` internal structure that also contained a `wasmer_exports_t` pointer (see #68). It simplifies the code since we don't have to destroy the exports everytime an error happens. Exports need to be destroyed only when the `wasm_instance` _resource_ is destroyed. It finally avoids an allocation for exports everytime an exported function is invoked. Co-authored-by: Ivan Enderlin <ivan.enderlin@hoa-project.net>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
wasm_instancestructure. It holds awasmer_instance_tpointer and awasmer_exports_tpointer. Thus, it simplifies theWasmArrayBufferinternal structure that also contained awasmer_exports_tpointer (see #68).It simplifies the code since we don't have to destroy the exports everytime an error happens. Exports need to be destroyed only when the
wasm_instanceresource is destroyed.It finally avoids an allocation for exports everytime an exported function is invoked.